Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] fix(marketplace): add MUI v5 workaround to marketplace wrapper, similar to other plugins #2578

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Mar 14, 2025

Description

Will update screenshots when a container image is available.

Currently the extensions drawer looks like this It should look like this
Screenshot from 2025-03-14 12-18-14 Screenshot from 2025-03-14 12-06-50
RHDH Version: 1.5.0
Backstage Version: 1.35.1
Upstream: rhdh release-1.5 @ 2d7b812
Midstream: rhdh rhdh-1.5-rhel-9 @ 04c0d061
Build Time: 2025-03-12T08:35:41Z
localhost, how it should look like

Will update screenshots when a container image is available.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Test marketplace on a cluster

…ar to other plugins

Signed-off-by: Christoph Jerolimov <[email protected]>
Copy link
Contributor

@christoph-jerolimov christoph-jerolimov marked this pull request as draft March 14, 2025 12:40
@christoph-jerolimov christoph-jerolimov marked this pull request as ready for review March 17, 2025 11:00
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Mar 25, 2025
Copy link
Contributor

@nickboldt
Copy link
Member

nickboldt commented Mar 26, 2025

Added link to relevant JIRA: https://issues.redhat.com/browse/RHIDP-6411

See also #2577 (for main branch)

Copy link

openshift-ci bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: psrna
Once this PR has been reviewed and has the lgtm label, please ask for approval from christoph-jerolimov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt merged commit cc97f0a into redhat-developer:release-1.5 Mar 26, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants